Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/993/pullrequest.html

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/993/pullrequest.html

An automated preview of the documentation is available at https://993.json.prtest2.cppalliance.org/libs/json/doc/html/index.html

An automated preview of the documentation is available at https://993.json.prtest2.cppalliance.org/libs/json/doc/html/index.html

An automated preview of the documentation is available at https://993.json.prtest2.cppalliance.org/libs/json/doc/html/index.html

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.50%. Comparing base (2df2366) to head (bcb9865).
⚠️ Report is 1 commits behind head on develop.

@@             Coverage Diff             @@
##           develop     #993      +/-   ##
===========================================
- Coverage    93.71%   93.50%   -0.22%     
===========================================
  Files           91       85       -6     
  Lines         9156     8840     -316     
===========================================
- Hits          8581     8266     -315     
+ Misses         575      574       -1     

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/993/pullrequest.html

An automated preview of the documentation is available at https://993.json.prtest2.cppalliance.org/libs/json/doc/html/index.html

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/993/pullrequest.html

An automated preview of the documentation is available at https://993.json.prtest2.cppalliance.org/libs/json/doc/html/index.html

An automated preview of the documentation is available at https://993.json.prtest2.cppalliance.org/libs/json/doc/html/index.html

An automated preview of the documentation is available at https://993.json.prtest2.cppalliance.org/libs/json/doc/html/index.html

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/993/pullrequest.html

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/993/pullrequest.html

This is crashing the s390 runners. out-of-memory.
The PR was opened 10 months ago. Have you rebased it on develop?
I now adjusted those runners from 2 jobs to 1 job. Try it again.

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/993/pullrequest.html

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/993/pullrequest.html

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/993/pullrequest.html

I did rebase it on develop.

It is quite interesting that the build is crashing s390 runners. This might be a problem with Boost.Charconv.

An automated preview of the documentation is available at https://993.json.prtest2.cppalliance.org/libs/json/doc/html/index.html

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/993/pullrequest.html

This might be a problem with Boost.Charconv.

It used more than 8GB of memory.

I have just kicked off another run on 'develop', to compare that.

Depending on the test, even the develop branch may get to nearly 8GB.
Charconv is not the cause.
I don't think JSON was using that much memory a couple years ago.
In any case the runner is now parallel-jobs=1 so more memory is available.

I've recorded memory usage when building and running tests. The outlier is pretty much compiling parse_into.cpp:

Everthing else is below 0.9GB (https://gist.github.com/grisumbras/5985960c7781c4f657a93605d9e2b0ed).

Unfortuantely, this is inherent to parse_into.cpp. It's very template-heavy. I think, the way we should deal with this is to move it to a separate build target, and run b2 twice: one for regular jobs with regular job count limit, and then the heavy tests one job at a time.

BTW, for posterity, the info was collected thusly:

# user-config.jam
using gcc : 13 : /usr/bin/time "-f%C|%M" -o/home/grisumbras/dev/stats -a g++-13 ;
using clang : 20 : /usr/bin/time "-f%C|%M" -o/home/grisumbras/dev/stats -a clang++-20 ;

And then b2 was invoked with

rm /home/grisumbras/dev/stats
b2 test example toolset=gcc,clang variant=debug,release cxxstd=17,20 warnings=extra testing.launcher="/usr/bin/time -f'%C|%M' -o/home/grisumbras/dev/stats -a"

After that the file /home/grisumbras/dev/stats contained collected statistics.

An automated preview of the documentation is available at https://993.json.prtest2.cppalliance.org/libs/json/doc/html/index.html

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/993/pullrequest.html

An automated preview of the documentation is available at https://993.json.prtest2.cppalliance.org/libs/json/doc/html/index.html

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/993/pullrequest.html

An automated preview of the documentation is available at https://993.json.prtest2.cppalliance.org/libs/json/doc/html/index.html

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/993/pullrequest.html

An automated preview of the documentation is available at https://993.json.prtest2.cppalliance.org/libs/json/doc/html/index.html

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/993/pullrequest.html

An automated preview of the documentation is available at https://993.json.prtest2.cppalliance.org/libs/json/doc/html/index.html

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/993/pullrequest.html